Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using array of array notation for sort triggers an error when followed by .toConstructor() #8159

Closed
MehdiSaffar opened this issue Sep 12, 2019 · 0 comments
Closed

Using array of array notation for sort triggers an error when followed by .toConstructor() #8159

MehdiSaffar opened this issue Sep 12, 2019 · 0 comments
Labels
confirmed-bug We've confirmed this is a bug in Mongoose and will fix it.
Milestone
5.7.2

Comments

@MehdiSaffar
Copy link

Query.prototype.sort() accepts array of arrays. When I add .toConstructor() it crashes saying

Invalid sort() argument, must be array of arrays
   at Query.sort (/xxx/node_modules/mquery/lib/mquery.js:1256:15)
   at Query.sort (/xxx/node_modules/mongoose/lib/query.js:2536:26)
   at Query.setOptions (/xxx/node_modules/mquery/lib/mquery.js:187:20)
   at Query.setOptions (/xxx/node_modules/mongoose/lib/query.js:1367:32)
   at model.Query.toConstructor (/xxx/node_modules/mongoose/lib/query.js:191:5)

NodeJS: v12.6.0
Mongoose: 5.7.0
MongoDB: irrelevant
@vkarpov15 vkarpov15 added this to the 5.7.2 milestone Sep 19, 2019
@vkarpov15 vkarpov15 added the needs repro script Maybe a bug, but no repro script. The issue reporter should create a script that demos the issue label Sep 19, 2019
vkarpov15 added a commit to mongoosejs/mquery that referenced this issue Sep 22, 2019
@vkarpov15
fix: dont re-call setOptions() when pulling base class options
b36dfd8 
Re: Automattic/mongoose#8159
@vkarpov15 vkarpov15 added confirmed-bug We've confirmed this is a bug in Mongoose and will fix it. and removed needs repro script Maybe a bug, but no repro script. The issue reporter should create a script that demos the issue labels Sep 22, 2019
vkarpov15 added a commit that referenced this issue Sep 22, 2019
@vkarpov15
test(query): repro #8159
1e0cc7a
This was referenced Mar 11, 2021
Merged
Open
Open
Closed
Merged
Open
Merged
Closed
Merged
Merged
Closed
Open
Open
This was referenced Mar 18, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug We've confirmed this is a bug in Mongoose and will fix it.
Projects
None yet
Milestone
5.7.2
Development

No branches or pull requests
2 participants
@vkarpov15 @MehdiSaffar