Typings: ValidationError should only contain ValidatorErrors or CastErrors #11369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanHafez
approved these changes
Feb 18, 2022
|
Thank you Hafez. Yes splitting the typings should make it easier to handle them better. I also extracted the Connection Typings in #11418 . Please have a look at it. Here i didnt write any additional tests, because it would be kind of waste of time. But in the Connection Types PR I wrote alot of typings tests. |
vkarpov15
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11367
Extracted Error-typings from index.d.ts
renamed class Error to class MongooseError to ensure we extend from MongooseError and not from global.Error class
added typings test for #11367
fixed the issue #11367