fix(query): cast $pull using embedded discriminator schema when discriminator key is set in filter #14676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iminator key is set in filter Fix #14675
hasezoey
approved these changes
Jun 21, 2024
This was referenced Jul 16, 2024
Open
This was referenced Jul 17, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14675
Summary
For other update operators, we correctly handle casting embedded discriminator paths when we can infer the embedded discriminator type from the filter. But looks like not for
$pull. This PR fixes that.We should really clean up the duplicated
_getSchema()followed bygetEmbeddedDiscriminatorPath()calls. Looks like the only reason why we need to call_getSchema()is because of$fullPath, but we need to investigate some more to figure that out.Examples