-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gam): support fluid ad unit sizing #196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
adekbadek
requested changes
Oct 18, 2021
adekbadek
approved these changes
Oct 19, 2021
Thank you, @adekbadek ! Do you mind taking another quick look? I had to merge #202 |
adekbadek
approved these changes
Oct 19, 2021
🎉 This PR is included in version 1.18.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for GAM's fluid ad unit size. Fluid is supported multisized or not for both AMP and AMP Plus.
00cee00 added a fix to fluid rendering on AMP Plus. GPT currently sets the iframe with
min-width
set to100%
andwidth
attribute set to0
. This causes theiframe
to be rendered with0
width. The fix listens to rendered slot and updates the width if native content is identified.How to test changes
Note: There's a known issue with AMP that sometimes won't render ads that are loaded on the viewport. Make sure to put the ads outside of the initial viewport and will require you to scroll to the ad for it to properly load.
Closes #195