Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support overlay walls in Campaigns #2191

Closed
wants to merge 1 commit into from
Closed

feat: support overlay walls in Campaigns #2191

wants to merge 1 commit into from

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Dec 14, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds segmentation UI to enable overlay walls per segment.

How to test the changes in this Pull Request:

See instructions in Automattic/newspack-popups#1030.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added [Type] Feature request Request for new features [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 14, 2022
@dkoo dkoo requested a review from a team as a code owner December 14, 2022 23:32
@dkoo dkoo self-assigned this Dec 14, 2022
@dkoo dkoo marked this pull request as draft December 14, 2022 23:37
@dkoo dkoo mentioned this pull request Dec 14, 2022
Closed
6 tasks
@dkoo dkoo closed this Jan 15, 2024
@dkoo dkoo deleted the feat/overlay-walls branch January 15, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dkoo dkoo

Labels
[Status] Needs Review The issue or pull request needs to be reviewed [Type] Feature request Request for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dkoo