Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #24.
Because of lack of AMP callbacks, this focus trap is activated in a somewhat hacky way, and there's no way to deactivate it – which results in a JS error being thrown after the campaign is dismissed.
Ideally, we should use the focus trap as part of the general non-AMP JS refactor (replacing AMP scripts with bespoke JS) – so this is a POC.
How to test the changes in this Pull Request:
Other information: