Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 20 to CI #2237

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Add Node 20 to CI #2237

merged 3 commits into from
Apr 27, 2023

Conversation

hargasinski
Copy link
Contributor

Node 20 was recently released. This PR adds support for it to ci.

  • Have you updated CHANGELOG.md?

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have it in CI, thanks.

prebuild.yaml is used in the prebuilds branch, not the master branch, but we can update that next time we make prebuilds.

@hargasinski
Copy link
Contributor Author

It looks like one of the linux tests failed, but it looks like it's related to a timeout.

prebuild.yaml is used in the prebuilds branch, not the master branch, but we can update that next time we make prebuilds.

Is there anything I could help with?

@zbjornson zbjornson merged commit adf73ee into Automattic:master Apr 27, 2023
@zbjornson
Copy link
Collaborator

I'll try to start the prebuilds for Node 20 now. Thanks!

@zbjornson zbjornson changed the title Prebuild binaries for Node 20 Add Node 20 to CI Apr 27, 2023
@zbjornson
Copy link
Collaborator

Prebuilds done for v2.11.2!

@hargasinski
Copy link
Contributor Author

Prebuilds done for v2.11.2!

Great, thanks!

@hargasinski hargasinski deleted the support-node-20 branch April 27, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants