-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: enable source context upload to Sentry #1966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @wzieba !
I have reviewed this PR and everything LGTM, good job! 🌟
Sentry pushed to their SaaS our contribution (getsentry/rust-proguard#36) which enables projects with R8 full mode to be correctly deobfuscated on Sentry dashboard.
Awesome work there and congrats on this contribution of youors pushed into Sentry's Saas! 🎉
So now it makes sense to send source context to their servers and benefit from more details when investigating issues on Sentry.
👍 but what I don't understand is how to (kind of) test it. I know you said it is not needed, but I got curious and was trying to find a release
issue on Sentry that would give me SourceFile
instead of the correct name of the file.
Can you help point me to such issue? 🙏
For example looking at this issue I could see the correct name of the file already. I am more curious than anything else...
Thanks @ParaskP7 for the reviews! Let me give you more context
Because Sentry pushed the change to SaaS, you won't see |
Thanks for the additional context here @wzieba , this is exactly what I was thinking as well, but then, my more targeted question is, why do we need to set the |
Oh cool @wzieba , this helps a lot, thanks for providing examples to explain that to me, much appreciated! 🙇 |
Description
Sentry pushed to their SaaS our contribution (getsentry/rust-proguard#36) which enables projects with R8 full mode to be correctly deobfuscated on Sentry dashboard.
So now it makes sense to send source context to their servers and benefit from more details when investigating issues on Sentry.
Testing Instructions
Not needed: see screenshots below.
Screenshots or Screencast
Source context is uploaded:
Sentry shows the source code around the stacktrace records
See: https://a8c.sentry.io/issues/5547984676/?project=6711064&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=1h&stream_index=0&utc=true
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...