-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable clip sharing in the release variant #2707
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That release build worked well.
I noticed a couple of things that aren't related to this PR, but I thought I should mention them. Neither of them is a big deal, so feel free to ignore them.
The Wear OS APK is 136MB. I understand it will be smaller in the final version, but is it possible to exclude the feature from the Wear OS version as it isn't used, or is this too tricky?
When creating a clip, if I tap play to listen to it, I can't move the finishing bar without the playback stopping. It would be nice if the finishing bar didn't stop the playback if it's after the playback position. It would make it easier to extend the clip.
Good point. I'll address that.
It's not available in the ExoPlayer APIs. Selecting a new position requires creating a new |
827059f
to
ee5afa3
Compare
Fixed in #2715 |
7af9c55
to
49a2487
Compare
Description
This enables the Reimagine Sharing in release variants. I'll wait with merging this until "What's New" is ready next week.
Testing Instructions
release
variant of the app.Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesAll strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previewsI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...