Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clip sharing in the release variant #2707

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Aug 23, 2024

Description

This enables the Reimagine Sharing in release variants. I'll wait with merging this until "What's New" is ready next week.

Testing Instructions

  1. Build release variant of the app.
  2. Smoke test clip sharing.
  3. Smoke test podcast sharing.
  4. Smoke test episode sharing.
  5. Smoke test episode position sharing.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added this to the 7.72 milestone Aug 23, 2024
@MiSikora MiSikora requested a review from a team as a code owner August 23, 2024 09:44
@MiSikora MiSikora requested review from geekygecko and removed request for a team August 23, 2024 09:44
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 23, 2024

4 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ Class CardCoordinates is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class NoOpMediaService is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 23, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit49a2487
Direct Downloadpocketcasts-app-prototype-build-pr2707-49a2487.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit49a2487
Direct Downloadpocketcasts-automotive-prototype-build-pr2707-49a2487.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit49a2487
Direct Downloadpocketcasts-wear-prototype-build-pr2707-49a2487.apk

Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That release build worked well.

I noticed a couple of things that aren't related to this PR, but I thought I should mention them. Neither of them is a big deal, so feel free to ignore them.

The Wear OS APK is 136MB. I understand it will be smaller in the final version, but is it possible to exclude the feature from the Wear OS version as it isn't used, or is this too tricky?

When creating a clip, if I tap play to listen to it, I can't move the finishing bar without the playback stopping. It would be nice if the finishing bar didn't stop the playback if it's after the playback position. It would make it easier to extend the clip.

@MiSikora
Copy link
Contributor Author

MiSikora commented Aug 26, 2024

The Wear OS APK is 136MB. I understand it will be smaller in the final version, but is it possible to exclude the feature from the Wear OS version as it isn't used, or is this too tricky?

Good point. I'll address that.

When creating a clip, if I tap play to listen to it, I can't move the finishing bar without the playback stopping. It would be nice if the finishing bar didn't stop the playback if it's after the playback position. It would make it easier to extend the clip.

It's not available in the ExoPlayer APIs. Selecting a new position requires creating a new MediaItem, I don't want to manually handle whether we should stop playback and prefer to let ExoPlayer do it..

@MiSikora
Copy link
Contributor Author

The Wear OS APK is 136MB. I understand it will be smaller in the final version, but is it possible to exclude the feature from the Wear OS version as it isn't used, or is this too tricky?

Fixed in #2715

@MiSikora MiSikora enabled auto-merge (squash) August 28, 2024 13:55
@MiSikora MiSikora merged commit 422e8e3 into main Aug 28, 2024
15 of 16 checks passed
@MiSikora MiSikora deleted the task/reimagine-sharing branch August 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants