Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed this issue in Sentry. It is related to my changes introducing auto play through deep link. When trying to avoid auto playing on configuration changes I inadvertently prevented view model from being set up after process death.
Testing Instructions
Fix
adb shell am kill au.com.shiftyjelly.pocketcasts.debug
.Auto play
adb shell am start -n au.com.shiftyjelly.pocketcasts.debug/au.com.shiftyjelly.pocketcasts.ui.MainActivity -a android.intent.action.VIEW -d "https://pca.st/episode/49900dc4-d6de-4673-b894-2da321b307d0?auto_play=true"
adb shell am start -n au.com.shiftyjelly.pocketcasts.debug/au.com.shiftyjelly.pocketcasts.ui.MainActivity -a android.intent.action.VIEW -d "https://pca.st/episode/49900dc4-d6de-4673-b894-2da321b307d0?auto_play=true"
.adb shell am kill au.com.shiftyjelly.pocketcasts.debug
.Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApply
to automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesAll strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previewsI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...