Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sleep Timer] Fix - Volume doesn't return to original level if device is shaken during fade-out #2930

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Sep 25, 2024

Description

  • This restore the original player volume after restarting sleep timer by shaking the device

Fixes #2440

Testing Instructions

  1. Set timer and start episode. I would set 1 minute for this step
  2. When time starts to fade out, shake device. It starts fading out when have 5 seconds left, but to see the issue I recommend to shake the device when it has 2 or 3 seconds left
  3. Wait for sleep timer being restarted
  4. ✅ Ensure the player volume returns to the original one before shaking the device

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added this to the 7.74 milestone Sep 25, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner September 25, 2024 16:57
@mebarbosa mebarbosa requested review from ashiagr and removed request for a team September 25, 2024 16:57
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 25, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit54d6168
Direct Downloadpocketcasts-app-prototype-build-pr2930-54d6168.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit54d6168
Direct Downloadpocketcasts-automotive-prototype-build-pr2930-54d6168.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit54d6168
Direct Downloadpocketcasts-wear-prototype-build-pr2930-54d6168.apk

@mebarbosa mebarbosa added the [Type] Bug Not functioning as intended. label Sep 25, 2024
@mebarbosa mebarbosa force-pushed the fix/player-volume-after-shaking-device branch from ce37d10 to 54d6168 Compare September 26, 2024 10:49
@mebarbosa mebarbosa enabled auto-merge (squash) September 26, 2024 10:59
@mebarbosa mebarbosa merged commit 4394598 into main Sep 26, 2024
15 of 16 checks passed
@mebarbosa mebarbosa deleted the fix/player-volume-after-shaking-device branch September 26, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] Sleep Timer [Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sleep Timer: Volume doesn't return to original level if device is shaken during fade-out
3 participants