Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change WatchOS minimum deployment target to 8 #1253

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Change WatchOS minimum deployment target to 8 #1253

merged 1 commit into from
Dec 4, 2023

Conversation

leandroalonso
Copy link
Member

Fixes #1217

This attempts to fix the issue of the app not installing on WatchOS 8.8.1. As per:

Thanks to a tip from the developers of another app, we found that changing the deployment target of the watch app from watchOS 7 to watchOS 8, allowed the app to be installed on devices running watchOS 8.
Since all devices that supported watchOS 7 also support watchOS 8, this was an acceptable workaround and we have now released an app update with this change.

To test

  1. Run the Pocket Casts Watch App target
  2. ✅ It should run

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@leandroalonso leandroalonso added the [Area] watchOS Issus related to watchOS label Dec 4, 2023
@leandroalonso leandroalonso added this to the 7.53 ❄️ milestone Dec 4, 2023
@leandroalonso leandroalonso requested a review from a team as a code owner December 4, 2023 20:00
@leandroalonso leandroalonso changed the title Change watch OS minimum deployment target to 8 Change WatchOS minimum deployment target to 8 Dec 4, 2023
emilylaguna
emilylaguna approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@leandroalonso leandroalonso merged commit e016dc9 into release/7.53 Dec 4, 2023
1 of 2 checks passed
@leandroalonso leandroalonso deleted the watch/attempt-to-fix-running-on-watch-os-8 branch December 4, 2023 20:05
@M-Krieger M-Krieger mentioned this pull request Feb 9, 2024
Closed
@bgoncal bgoncal mentioned this pull request Feb 27, 2024
Merged
bgoncal added a commit to home-assistant/iOS that referenced this pull request Feb 29, 2024
@bgoncal
Attempt to fix issue where app is not installed on watchOS 8 (#2609)
536c3ad 
<!-- Thank you for submitting a Pull Request and helping to improve Home
Assistant. Please complete the following sections to help the processing
and review of your changes. Please do not delete anything from this
template. -->

## Summary
<!-- Provide a brief summary of the changes you have made and most
importantly what they aim to achieve -->
Workaround reference:
Automattic/pocket-casts-ios#1253

## Screenshots
<!-- If this is a user-facing change not in the frontend, please include
screenshots in light and dark mode. -->

## Link to pull request in Documentation repository
<!-- Pull requests that add, change or remove functionality must have a
corresponding pull request in the Companion App Documentation repository
(https://github.com/home-assistant/companion.home-assistant). Please add
the number of this pull request after the "#" -->
Documentation: home-assistant/companion.home-assistant#

## Any other notes
<!-- If there is any other information of note, like if this Pull
Request is part of a bigger change, please include it here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna emilylaguna approved these changes

Assignees
No one assigned
Labels
[Area] watchOS Issus related to watchOS
Projects
None yet
Milestone
7.53
Development

Successfully merging this pull request may close these issues.
2 participants
@leandroalonso @emilylaguna