-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily update fastlane to fix transporter issue #232
Conversation
@@ -9,7 +9,7 @@ gem 'danger' | |||
gem 'danger-rubocop', '~> 0.10' | |||
gem 'danger-swiftformat', git: 'https://github.com/shiftyjelly/danger-ruby-swiftformat.git' | |||
gem 'danger-swiftlint' | |||
gem 'fastlane' | |||
gem "fastlane", :git => "https://github.com/freddi-kit/fastlane.git", :branch => "altool-upload" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a task to myself to keep an eye on the original PR and revert that as soon as it's merged. fastlane/fastlane#20631
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -9,7 +9,7 @@ gem 'danger' | |||
gem 'danger-rubocop', '~> 0.10' | |||
gem 'danger-swiftformat', git: 'https://github.com/shiftyjelly/danger-ruby-swiftformat.git' | |||
gem 'danger-swiftlint' | |||
gem 'fastlane' | |||
gem "fastlane", :git => "https://github.com/freddi-kit/fastlane.git", :branch => "altool-upload" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -9,7 +9,7 @@ gem 'danger' | |||
gem 'danger-rubocop', '~> 0.10' | |||
gem 'danger-swiftformat', git: 'https://github.com/shiftyjelly/danger-ruby-swiftformat.git' | |||
gem 'danger-swiftlint' | |||
gem 'fastlane' | |||
gem "fastlane", :git => "https://github.com/freddi-kit/fastlane.git", :branch => "altool-upload" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 | Use the new Ruby 1.9 hash syntax. |
Temporarily update fastlane to fix transporter issue
Temporarily update fastlane to fix transporter issue
Upload to App Store Connect is failing due to missing
transporter
:To test
Green CI is Happy CI.
Checklist
CHANGELOG.md
if necessary.