Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve the keyboard when clearing the search text on Discover #321

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Preserve the keyboard when clearing the search text on Discover #321

merged 2 commits into from
Sep 29, 2022

Conversation

chipsnyder
Copy link
Contributor

Fixes #110

Preserve the keyboard when clearing the search text on Discover by removing the explicit call that resigns the first responder.

To test

  1. Go to Discover
  2. Tap the search input
  3. Enter some text
  4. Tap the "X" button
  5. Ensure the keyboard remains

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@chipsnyder chipsnyder added the [Type] Bug Used for issues where something is not functioning as intended. label Sep 29, 2022
@chipsnyder chipsnyder marked this pull request as ready for review September 29, 2022 20:30
@chipsnyder chipsnyder requested a review from a team as a code owner September 29, 2022 20:30
@emilylaguna emilylaguna self-assigned this Sep 29, 2022
emilylaguna
emilylaguna approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!!

@chipsnyder chipsnyder added this to the 7.24 milestone Sep 29, 2022
@chipsnyder chipsnyder merged commit 69bf96a into trunk Sep 29, 2022
@chipsnyder chipsnyder deleted the issue/chip/110-discoverKeyboard branch September 29, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna emilylaguna approved these changes

Assignees

@chipsnyder chipsnyder

Labels
[Type] Bug Used for issues where something is not functioning as intended.
Projects
None yet
Milestone
7.24 ❄️
Development

Successfully merging this pull request may close these issues.

Search: when clearing the search term the keyboard disappears
2 participants
@chipsnyder @emilylaguna