Add student action menu to Student Management page #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing that we have an example to do it! What do you think about adding at least 1 test just to make sure that any special requirement is necessary to write tests? |
Good idea! Will add some at some point this week. 🙂 |
|
@gabrielcaires I added a test case. I had to take the Also, when this PR is approved I think I will go ahead and merge it. We can iterate on the implementation when we get to the task to hook up the click events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR tries using the
DropdownMenucomponent from the@wordpress/componentspackage on the Student Management page. It passes incourseIdas a prop, which is logged to the console for demonstration purposes. This would obviously need to change later on to be auserIdprop. We can take over this PR when it comes time to hook up the menu.Note: This PR is not meant to be merged as-is. We can use it to implement the action menu though once the other dependencies are ready.
Testing instructions
npm run build.Screenshots