Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Student Management" to "Students" #4981

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Apr 4, 2022

Related to the issue #4958

Changes proposed in this Pull Request

Rename the admin/"Students Management" page to Students on the menu and title.

Testing instructions

  • Open the admin page
  • Check if the menu and the page title were renamed as this screenshot https://d.pr/QKkmca

@gabrielcaires gabrielcaires requested a review from a team April 4, 2022 12:39
@gabrielcaires gabrielcaires added this to the 4.4.0 milestone Apr 4, 2022
@gabrielcaires gabrielcaires self-assigned this Apr 4, 2022
@LavaGolem
Copy link
Contributor

LavaGolem commented Apr 4, 2022

Can confirm that both the page title and the menu item are Students. Since we have separate tasks for "Update header and navigation, add support link." I will approve this

Just one note on the PR description, it should include an indicator of the issue, so it should start with "Relates to #4958" for
this issue: #4958

image

@gabrielcaires gabrielcaires merged commit 31f89ae into feature/student-management Apr 4, 2022
@gabrielcaires gabrielcaires deleted the update/rename-student-management-page branch April 4, 2022 22:04
@donnapep donnapep changed the title Rename the admin/students page Rename "Student Management" to "Students" Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants