Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email column and remove enrollment column from student management table #4986

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add email column and remove enrollment column from student management table #4986

merged 1 commit into from
Apr 6, 2022

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Apr 5, 2022

Partial work for #4958

Changes proposed in this Pull Request

Removed enrollment column and added email column for students.

Testing instructions

  1. Create a few courses
  2. Create a few students
  3. Add them to courses
  4. Go to SenseiLMS->Students
  5. Make sure the email column is there and the enrollment column isn't

Screenshot / Video

image

@Imran92 Imran92 added this to the 4.4.0 milestone Apr 5, 2022
@Imran92 Imran92 requested a review from a team April 5, 2022 10:47
@Imran92 Imran92 self-assigned this Apr 5, 2022
gabrielcaires
gabrielcaires approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@gabrielcaires gabrielcaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Imran92 Imran92 merged commit dcf46bc into feature/student-management Apr 6, 2022
@Imran92 Imran92 deleted the update/student_management_change_table_columns branch April 6, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcaires gabrielcaires gabrielcaires approved these changes

Assignees

@Imran92 Imran92

Labels
Learner Management
Projects
None yet
Milestone
4.4.0 - Student Management
Development

Successfully merging this pull request may close these issues.
2 participants
@Imran92 @gabrielcaires