Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Add Students CTA when there are no students on the course #5014

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

merkushin
Copy link
Member

Fixes part of #4958

Changes proposed in this Pull Request

  • Display Add Students button if a course is selected, but no students found.

Testing instructions

  • Create a new course.
  • Go to Students.
  • Select your new course in Filter By Course and apply filter.
  • You see Add Students button.

Screenshot / Video

CleanShot 2022-04-12 at 00 43 33@2x

CleanShot 2022-04-12 at 00 44 16@2x

CleanShot 2022-04-12 at 00 44 25@2x

@merkushin
Copy link
Member Author

@Luchadores
I wasn't sure what should I do on the click by the Add Students button.
I decided to send the user to the following screen:
Student Management - Courses - Manage Students

Is that correct behavior?

@Luchadores
Copy link

@merkushin 👋

I would say it's perfect for now. In the future, we will introduce a new way of adding students. Until then, this should be fine. @burtrw to have a look as well. 😄

}
.sensei-students__call-to-action div {
margin: 8px auto;
}
Copy link
Contributor

@Imran92 Imran92 Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can shorten it like this

.sensei-students__call-to-action {
	display: flex;
	flex-flow: column;
	margin: 20px auto;
	
    div {
		margin: 8px auto;
    }
}

Copy link
Member Author

@merkushin merkushin Apr 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Imran92! Updated PR.

Imran92
Imran92 previously approved these changes Apr 12, 2022
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works well 👍 Just have a small point about the SCSS

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍

@merkushin merkushin merged commit 6a2db55 into feature/student-management Apr 13, 2022
@merkushin merkushin deleted the update/empty-list-cta branch April 13, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants