-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Add Students CTA when there are no students on the course #5014
Conversation
@Luchadores Is that correct behavior? |
I would say it's perfect for now. In the future, we will introduce a new way of adding students. Until then, this should be fine. @burtrw to have a look as well. 😄 |
assets/css/admin-custom.scss
Outdated
} | ||
.sensei-students__call-to-action div { | ||
margin: 8px auto; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can shorten it like this
.sensei-students__call-to-action {
display: flex;
flex-flow: column;
margin: 20px auto;
div {
margin: 8px auto;
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Imran92! Updated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works well 👍 Just have a small point about the SCSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 👍
Fixes part of #4958
Changes proposed in this Pull Request
Testing instructions
Students
.Filter By Course
and apply filter.Add Students
button.Screenshot / Video