Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update students per course table column header and content #5021

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Update students per course table column header and content #5021

merged 3 commits into from
Apr 19, 2022

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Apr 13, 2022

Part of #4957

Changes proposed in this Pull Request

In the student per course page, changed the column header student to students, enrollment to enrolled.
Changed the content of enrolled to Yes/No replacing the previous way of showing different statuses. Also removed the icon from the left of course status, fixed some padding for a better view on desktop and mobile. Also refactored some codes to simplify.

Testing instructions

  • Create a few courses
  • Create a few students
  • Enrol a few students in those courses
  • Complete a few, leave a few enrolled but fully incomplete and partially complete, leave a few unenrolled.
  • Go to SenseiLMS->Students. Select a course from the course progress column
  • Check if the column headers and values are loading as expected for different courses and students
  • Check the table on mobile as well

Screenshot / Video

Desktop -
image
Mobile -
image

Update students per course table header and content
5d6fc19 
Changed header student to students, enrollment content to Yes/No, removed course status icon, fixed some padding and simplified some code
@Imran92 Imran92 added this to the 4.4.0 - Student Management milestone Apr 13, 2022
@Imran92 Imran92 requested a review from a team April 13, 2022 10:28
@Imran92 Imran92 self-assigned this Apr 13, 2022
merkushin
merkushin reviewed Apr 14, 2022
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I found only one difference from the proposed design: there should be a dash when the course is incomplete yet.
Design:
CleanShot 2022-04-14 at 14 15 43@2x

Current version:
CleanShot 2022-04-14 at 14 07 04@2x

@Imran92
Copy link
Contributor Author

Imran92 commented Apr 16, 2022

Oh! :p Good catch @merkushin <3 I've updated the PR, can you kindly take a look again?

@Imran92 Imran92 merged commit 12207f7 into feature/student-management Apr 19, 2022
@Imran92 Imran92 deleted the update/header-and-content-change-student-per-course branch April 19, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin approved these changes

Assignees

@Imran92 Imran92

Labels
Student Management [Type] Enhancement
Projects
None yet
Milestone
4.4.0 - Student Management
Development

Successfully merging this pull request may close these issues.
2 participants
@Imran92 @merkushin