-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reset or Remove Progress
action item
#5031
Add Reset or Remove Progress
action item
#5031
Conversation
Works as expected 🗡️ Do we need package-lock.json pushed here? |
Removed! Thanks @LavaGolem Can you approve the PR? |
@gabrielcaires, does it contain your fix for DELETE method? Hmm, and for some reason the button in modal looks different for me (comparing to the screenshot in the description): Maybe that's some cache on my side =/ |
@merkushin No, the fix is here #5029. |
03297d7
to
e81fbbd
Compare
@merkushin Rebased. Image after reset the progress *Image on the course details * I think it is wrong, but considering we are removing this column, I think we don't need a new card, right?
Hum, are you using which npm version? maybe a new npm install + npm build ? |
I think I will fix it in my current card (Replace "Course Progress" with "Enrolled Courses" column).
That's my standard routine after changing the current branch :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that the endpoint is resetting the student's progress but the Course Progress it still says that the student has progress.
If a student hasn't started a course (i.e. the Status column is Not Started on the course details page), then choosing Reset or Remove Progress will remove their progress (i.e. the row for that student will be removed).
If a student has started a course (i.e. the Status column is In Progress on the course details page), then choosing Reset or Remove Progress will reset their progress to Not Started.
So it's currently working as intended and there isn't actually anything to fix here. I tested and saw that when a student has not started a course yet, choosing Reset or Remove Progress successfully removes the course from the Course Progress column.
I also see the same thing as @merkushin wrt to the button and have been meaning to look into it. This could be addressed in a separate PR though, especially since you're not able to reproduce it (I don't get checkmarks showing in the checkbox either, which is also weird):
Related to #4959
Changes proposed in this Pull Request
Remove or Reset Progress
item on the student action menu.Testing instructions
Reset Or Remove progress
is availableScreenshot / Video