Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV will contain only the searched items if exported after searching #5079

Merged
merged 2 commits into from
Apr 29, 2022
Merged

CSV will contain only the searched items if exported after searching #5079

merged 2 commits into from
Apr 29, 2022

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Apr 28, 2022

Fixes #4988

Changes proposed in this Pull Request

  • Tables in Reports weren't taking searched string into consideration when exported as CSV. It is fixed here. Also have added a test for the footer.

Testing instructions

  • Go to reports.
  • Do a filter by date/course depending on what page are you on. The table will be populated now
  • Do a search using the search box on top-right
  • Make sure search worked
  • Now export the csv for each report page
  • Make sure that they contains only the items you searched for

Screenshot / Video

image

@Imran92 Imran92 changed the base branch from trunk to feature/reports-v3 April 28, 2022 14:46
@Imran92 Imran92 requested a review from a team April 28, 2022 14:46
@Imran92 Imran92 self-assigned this Apr 28, 2022
merkushin
merkushin approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@merkushin merkushin added this to the 4.5.0 - Reports v3 milestone Apr 29, 2022
@Imran92 Imran92 merged commit ef59f85 into feature/reports-v3 Apr 29, 2022
@Imran92 Imran92 deleted the fix/csv-not-taking-filters-into-account branch April 29, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin approved these changes

Assignees

@Imran92 Imran92

Labels
Reports
Projects
None yet
Milestone
4.4.1 - Report Improvements
Development

Successfully merging this pull request may close these issues.

Exporting does not take search into account
3 participants
@Imran92 @merkushin @m1r0