-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lesson Details Step #5194
Merged
fjorgemota
merged 7 commits into
feature/course-lesson-wizard
from
add/lesson-details-step
May 27, 2022
Merged
Add Lesson Details Step #5194
fjorgemota
merged 7 commits into
feature/course-lesson-wizard
from
add/lesson-details-step
May 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it will be used also by the lesson details step, not only by the course details step (as it's the same image)
To maintain the standard according to the other stes.
aaronfc
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works well! 🎸
@@ -37,7 +37,7 @@ const CourseDetailsStep = ( { data: wizardData, setData: setWizardData } ) => { | |||
return ( | |||
<div className="sensei-editor-wizard-modal__columns"> | |||
<div className="sensei-editor-wizard-modal__content"> | |||
<h1>Course Details Step</h1> | |||
<h1>{ __( 'Create your course', 'sensei-lms' ) }</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆 nice catch!
Nice test coverage!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5132
Changes proposed in this Pull Request
Testing instructions
npm start
to compile the assets (or use the plugin build);npm run test-js
;