Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lesson Details Step #5194

Merged
merged 7 commits into from
May 27, 2022

Conversation

fjorgemota
Copy link
Member

@fjorgemota fjorgemota commented May 26, 2022

Fixes #5132

Changes proposed in this Pull Request

  • Rename image used for course details step to a generic name, to be reused by the lesson details step;
  • Do some small fixes on the Course Details Step (which I just noticed after the review);
  • Work a little bit on the Course Upgrade Step, renaming variables to maintain a pattern and also adding some tests;
  • Add the Lesson Details Step;
  • And add some tests to the Lesson Details Step;

Testing instructions

  1. Checkout this branch;
  2. Run npm start to compile the assets (or use the plugin build);
  3. Install the plugin in some WordPress installation, access the wp-admin of that WordPress installation;
  4. Create a course, and then create a lesson;
  5. Access that Lesson;
  6. Verify that you can edit the title of the lesson via the wizard that will open;
  7. Also verify that the JS tests pass, using npm run test-js;

@fjorgemota fjorgemota added this to the Course and Lesson Wizard milestone May 26, 2022
@fjorgemota fjorgemota self-assigned this May 26, 2022
@fjorgemota fjorgemota linked an issue May 26, 2022 that may be closed by this pull request
@fjorgemota fjorgemota marked this pull request as ready for review May 26, 2022 20:57
@fjorgemota fjorgemota requested a review from a team May 26, 2022 20:57
Copy link
Contributor

@aaronfc aaronfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well! 🎸

@@ -37,7 +37,7 @@ const CourseDetailsStep = ( { data: wizardData, setData: setWizardData } ) => {
return (
<div className="sensei-editor-wizard-modal__columns">
<div className="sensei-editor-wizard-modal__content">
<h1>Course Details Step</h1>
<h1>{ __( 'Create your course', 'sensei-lms' ) }</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 nice catch!

@fjorgemota fjorgemota merged commit c1016ab into feature/course-lesson-wizard May 27, 2022
@fjorgemota fjorgemota deleted the add/lesson-details-step branch May 27, 2022 12:46
@renatho
Copy link
Contributor

renatho commented May 27, 2022

Nice test coverage!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lesson Wizard - Create "Create your lesson" step
3 participants