Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Course Outline styles on pattern thumbnails #5261

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Jun 10, 2022

Fixes #5250

Changes proposed in this Pull Request

  • It fixes the Course Outline styles on pattern thumbnails.

Testing instructions

  • Create a new course.
  • In the wizard, navigate to the patterns step.
  • Check that the Course Outline appears correctly in the thumbnails.

Screenshot / Video

Screen Shot 2022-06-10 at 17 13 56

Notice that a part of the pattern is not appearing. It's because it doesn't crop the pattern 100% correctly. It also happens in other patterns:

Screen Shot 2022-06-10 at 17 14 54

@renatho renatho added this to the Course and Lesson Wizard milestone Jun 10, 2022
@renatho renatho requested a review from a team June 10, 2022 20:28
@renatho renatho self-assigned this Jun 10, 2022
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@renatho renatho merged commit 034ea11 into feature/course-lesson-wizard Jun 11, 2022
@renatho renatho deleted the fix/pattern-thumbnails-style branch June 11, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants