Add woothemes-sensei detection to the extensions API #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjorgemota
commented
Jun 16, 2022
Codecov Report
@@ Coverage Diff @@
## trunk #5282 +/- ##
=========================================
Coverage 40.75% 40.75%
Complexity 8616 8616
=========================================
Files 284 284
Lines 29042 29042
=========================================
Hits 11837 11837
Misses 17205 17205 Continue to review full report at Codecov.
|
alexsanford
reviewed
Jun 20, 2022
| const replaces = {}; | ||
|
|
||
| if ( wizardData.title ) { | ||
| replaces[ 'sensei-content-title' ] = wizardData.title; | ||
| } | ||
|
|
||
| const isSenseiProActivated = | ||
| ! senseiProExtension || senseiProExtension.is_activated === true; | ||
| const isSenseiProActivated = useHideEditorWizardUpsell(); |
There was a problem hiding this comment.
Could we update the variable naming to match the logic? So instead of isSenseiProActivated maybe we use shouldHideEditorWizardUpsell? (Also in the Course wizard below)
There was a problem hiding this comment.
Sure, fixed in 6ef29d3.
Co-authored-by: Alex Sanford <alex.sanford1@gmail.com>
fjorgemota
force-pushed
the
fix/woothemes-sensei-detection
branch
from
c3b049b
to
6ef29d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
woothemes-senseibased on this branch;/wp-admin/edit.php?post_type=course&page=sensei-extensions;I also recommend testing in another WordPress installation to check if both upsells don't appear when Sensei LMS (based on this branch) + Sensei Pro is installed and activated.