Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change confirm dialog styles #5454

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Change confirm dialog styles #5454

merged 1 commit into from
Aug 13, 2022

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Aug 12, 2022

Changes proposed in this Pull Request

  • It changes the confirm dialog styles.

Testing instructions

  • See 1670-gh-Automattic/sensei-pro

@renatho renatho added this to the 4.6.2 milestone Aug 12, 2022
@renatho renatho requested a review from a team August 12, 2022 22:57
@renatho renatho self-assigned this Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #5454 (16a2937) into trunk (5ff52a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #5454   +/-   ##
=========================================
  Coverage     44.54%   44.54%           
  Complexity     8749     8749           
=========================================
  Files           412      412           
  Lines         31166    31166           
  Branches        234      234           
=========================================
  Hits          13882    13882           
  Misses        17111    17111           
  Partials        173      173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a54a38...16a2937. Read the comment docs.

@fjorgemota fjorgemota linked an issue Aug 13, 2022 that may be closed by this pull request
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Looks good and works well!

@renatho renatho merged commit 7ef62e0 into trunk Aug 13, 2022
@renatho renatho deleted the change/confirm-dialog-styles branch August 13, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ConfirmDialog design
2 participants