Fix PHP 8.1 deprecation notice on Students page #7038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7029.
Proposed Changes
wp_kses
was the culprit becausenull
was being passed as the first parameter. This is because we were passing the result of the call torender_bulk_action_select_box
, which has no return value, sonull
was used instead. The net result was thatwp_kses
had no effect.This PR changes the implementation of
render_bulk_action_select_box
(and renames it) such that the HTML is returned. Now,null
is no longer passed towp_kses
and the call actually works. This became apparent when I realized that the dropdown wasn't displaying correctly, because theclass
attribute was being stripped out. So I addedclass
as part of the allowed HTML forwp_kses
.Testing Instructions
Pre-Merge Checklist