Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add success message styles #7209

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add success message styles #7209

merged 2 commits into from
Oct 12, 2023

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 9, 2023

Based on #7204

Proposed Changes

  • It just adds success styles to the sensei messages.

Testing Instructions

See https://github.com/Automattic/sensei-pro/pull/2435

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@renatho renatho requested a review from a team October 9, 2023 20:44
@renatho renatho self-assigned this Oct 9, 2023
@renatho renatho changed the base branch from trunk to add/styles-for-sensei-login-page October 9, 2023 20:44
@renatho renatho added this to the 4.17.1 milestone Oct 9, 2023
@renatho renatho marked this pull request as ready for review October 9, 2023 20:45
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #7209 (524436f) into add/styles-for-sensei-login-page (c4a2040) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                          Coverage Diff                           @@
##             add/styles-for-sensei-login-page    #7209      +/-   ##
======================================================================
+ Coverage                               50.03%   50.06%   +0.03%     
- Complexity                              10705    10721      +16     
======================================================================
  Files                                     601      601              
  Lines                                   45200    45231      +31     
  Branches                                  402      402              
======================================================================
+ Hits                                    22616    22647      +31     
  Misses                                  22257    22257              
  Partials                                  327      327              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a2040...524436f. Read the comment docs.

@renatho renatho modified the milestone: 4.17.1 Oct 9, 2023
@donnapep donnapep modified the milestones: 4.18.0, 4.19.0 Oct 11, 2023
Base automatically changed from add/styles-for-sensei-login-page to trunk October 12, 2023 08:46
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Imran92 Imran92 merged commit 009bc00 into trunk Oct 12, 2023
24 of 25 checks passed
@Imran92 Imran92 deleted the add/success-message-styles branch October 12, 2023 08:47
@donnapep donnapep modified the milestones: 4.19.0, 4.18.0 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants