Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon size on Sensei blocks appender #7316

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Nov 22, 2023

Resolves #7308

Proposed Changes

  • I fixed it originally with a Gutenberg PR: Fix DropdownMenu svg icon size WordPress/gutenberg#56450
  • But while it's not merged and to be fixed in the versions where it's broken, I'm sending this PR with a workaround. Basically, it just adds the missing width and height to the svg in the DropdownMenu component.

Testing Instructions

  1. Create a new course.
  2. Add a Course Outline block.
  3. Click on "+".
  4. Check that the icons are displayed correctly.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@renatho renatho self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #7316 (592cd74) into trunk (5389d5b) will not change coverage.
Report is 1 commits behind head on trunk.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7316   +/-   ##
=========================================
  Coverage     50.81%   50.81%           
  Complexity    11060    11060           
=========================================
  Files           611      611           
  Lines         46727    46727           
  Branches        404      404           
=========================================
  Hits          23744    23744           
  Misses        22656    22656           
  Partials        327      327           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e68aa...592cd74. Read the comment docs.

@renatho renatho added this to the 4.19.3 milestone Nov 22, 2023
@renatho renatho marked this pull request as ready for review November 22, 2023 19:11
@renatho renatho requested a review from a team November 22, 2023 19:14
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@donnapep donnapep modified the milestones: 4.19.3, 4.19.2 Nov 22, 2023
@renatho renatho merged commit f0604f1 into trunk Nov 22, 2023
24 of 25 checks passed
@renatho renatho deleted the fix/dropdown-menu-icon-size branch November 22, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The appender button styles are broken on the Course Outline block
3 participants