-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle empty module titles on saving the course from the tour #7652
Conversation
Test the previous changes of this PR with WordPress Playground. |
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Test the previous changes of this PR with WordPress Playground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can we add a test similar to these? https://github.com/Automattic/sensei/blob/trunk/assets/admin/tour/helper.test.js
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #7652 +/- ##
============================================
+ Coverage 51.84% 51.91% +0.06%
- Complexity 11436 11456 +20
============================================
Files 652 652
Lines 48656 48721 +65
Branches 470 475 +5
============================================
+ Hits 25228 25292 +64
+ Misses 23047 23045 -2
- Partials 381 384 +3
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thanks for testing @Imran92. Unfortunately, the steps module doesn't have any existing tests. What do you think about adding a card for covering the whole steps module with tests, and address it next time we'll have time for that? Update: I created an issue: #7656 |
Resolves #7625
The problem described in the issue happens when, while following the tour, the user doesn't set the module title.
The course structure can't be saved in this case, and it causes the issue that the expected “Edit Lesson” link doesn't appear in the toolbar.
Proposed Changes
Testing Instructions
CleanShot.2024-07-31.at.20.22.48.mp4
Pre-Merge Checklist