Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the tooltip for buttons be visible: fix z-index for tour container #7653

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

merkushin
Copy link
Member

Resolves #7628

Problem:
image

Tooltips appear below the container.

Proposed Changes

  • Fix z-index for the tour container.

Testing Instructions

  1. On a fresh website, create a course.
  2. Make sure you see the course tour in the editor.
  3. Make sure tooltips (“Minimize tour”, “Close tour”) appear above the tour container and are visible.
  4. Please check in different browsers.
CleanShot.2024-07-31.at.20.43.53.mp4

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • “Needs Documentation” label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@merkushin merkushin added this to the 4.24.2 milestone Aug 1, 2024
@merkushin merkushin requested a review from a team August 1, 2024 02:55
@merkushin merkushin self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Test the previous changes of this PR with WordPress Playground.

Copy link

github-actions bot commented Aug 1, 2024

Test the previous changes of this PR with WordPress Playground.

Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@merkushin merkushin merged commit 4272ec4 into trunk Aug 2, 2024
23 checks passed
@merkushin merkushin deleted the fix/tour-button-tooltips branch August 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Tour modal is covering its own tooltips
2 participants