Fix: Ensure plugin, theme, and WordPress updates succeed #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 6891-gh-Automattic/dotcom-forge, #100
Relates to: WordPress/playground-tools#178
Proposed Changes
A fix to prevent plugins, themes, and WordPress updates from failing was recently merged into the Emscripten repository in emscripten-core/emscripten#21964. The next Emscripten release is due in around two weeks time, at which point a new release for PHP-WASM will be needed. As it may take some time for these updates to happen, and due to the high priority of this bug, I propose a temporary patch so that the fix gets to Studio users a bit quicker.
In this PR, I've updated the existing PHP-WASM patch to include the fix for update errors.
Testing Instructions
Update an outdated plugin
Recording:
updates.mov
Update an outdated version of WordPress
Recording:
wordpress-update.mov
General smoke testing
Ensure no regressions by testing general functionality related to installations. It should still be possible to install plugins and themes as before.
Pre-merge Checklist