Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: creating a new site pulls assistant messages from another site #259

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

kozer
Copy link
Contributor

@kozer kozer commented Jun 17, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7762

Proposed Changes

This PR fixes a bug where when the user creates a new site, it keeps old selected site messages in AI assistant

Testing Instructions

  1. Create a new site.
  2. Go to the assistant tab and ask some questions.
  3. While being on that tab, add a new site.
  4. Ensure that the chat is updated with being in an empty state.
  5. Changing back to the old site must still displays the chats.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@kozer kozer requested a review from a team June 17, 2024 13:44
@kozer kozer self-assigned this Jun 17, 2024
Copy link
Contributor

@jeroenpf jeroenpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes work for me. When i create a new site while on the Assistant tab of an existing site, i see the empty state (welcome messages) of AI assistant for the new site.

@kozer kozer merged commit f68e2f0 into trunk Jun 18, 2024
10 checks passed
@kozer kozer deleted the fix/new_site_assistant_pulls_another branch June 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants