Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: AssistantIsThinking triggrers across multiple sites #260

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

kozer
Copy link
Contributor

@kozer kozer commented Jun 17, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/7767

Proposed Changes

This PR fixes a bug where when the chat "is thinking" , the loading indicator persists across multiple sites.

Testing Instructions

  1. Create two sites.
  2. Navigate to Studio AI Assistant tab, of the first one.
  3. Submit a prompt to the model; eg: "Give me a 3 paragraph text" ( in order to make the response to slow down and make easier to notice )
  4. You should be able to see the "thinking" indicator.
  5. Switch to another site.
  6. Ensure that the indicator is not there.
  7. Now switch to the first one.
  8. Ensure that you still see the indicator..

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@kozer kozer requested a review from a team June 17, 2024 14:08
@kozer kozer self-assigned this Jun 17, 2024
Copy link
Contributor

@jeroenpf jeroenpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! When i am waiting for a response i see the loading indicator but when i switch to another site i don't see it.

Also, i tried to have more than one site where I'm waiting for a response and it also works as expected.

@kozer kozer merged commit 2c6ffef into trunk Jun 18, 2024
10 checks passed
@kozer kozer deleted the fix/assistantIsThinking_across_sites branch June 18, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants