Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stratford: homepage headings in RTL do not align to the right #2551

Closed
wants to merge 1 commit into from

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Oct 5, 2020

Changes proposed in this Pull Request:

Some of the headings on the stratford homepage do no align right in an RTL locale. This commit ensures that all headings within a block group are right-aligned.

Before

image

After

image

Testing

Apply D49467-code patch:

In the site options, change the language to he or ar (or any RTL language)

Open https://stratforddemo.wordpress.com/

Check that the headings are right aligned. (The content won't be translated of course :) )

Related issue(s):

First reported p58i-9ow-p2#comment-47478

…n RTL locale.

This commit ensures that all headings withing a block group are right-aligned.
@ramonjd ramonjd requested review from jeffikus and a team October 5, 2020 23:39
@ramonjd ramonjd self-assigned this Oct 5, 2020
@ramonjd
Copy link
Member Author

ramonjd commented Oct 5, 2020

@andrewserong said:

I'm not sure but this might even be a CSS rule generated by the Varia -> child theme build process? From looking at the last commit on that file in Github: 709fbc5, so perhaps it needs to be changed in Varia and then the build script needs running again. At the very least, hopefully an issue or PR in that repo will get the ball rolling.

👋 Reviewers, could you confirm if this is true? If so, what's the best way to fix this issue on Stratford? Thank you!!

@andrewserong
Copy link
Member

@scruffian I thought you might have a good idea about how to get this change in, since it looks like you last touched this file via #2503 ?

@scruffian
Copy link
Member

@jeffikus can we keep this in mind for a future planning session?

@scruffian
Copy link
Member

I think we should do this a different way, see #2761

@scruffian
Copy link
Member

Actually looking at this some more, it seems to be a deliberate decision in Gutenberg that if a left align is set like this we respect it. See WordPress/gutenberg@916cbb0

I don't think we should change anything here. If we want the headings to change their alignment then we should align them with CSS rather than using the .has-text-align-left class.

@scruffian scruffian closed this Nov 3, 2020
@scruffian scruffian deleted the update/stratford-rtl-headings branch November 3, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n [Pri] Normal [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants