Add heading rules to varia based themes #2761
Conversation
varia/style-editor.css
Outdated
| .wp-block-group { | ||
| /* Treating H2 separately to account for legacy /core styles */ | ||
| } |
There was a problem hiding this comment.
Are we getting this empty rule because of the comment?
There was a problem hiding this comment.
seems like it. interestingly switching to a // comment removes it...
There was a problem hiding this comment.
Yeah, I think the Sass compiler completely removes // but it keeps /* … */.
I believe there’s a separate, later script on wpcom that minifies each theme stylesheet which removes all code comments in CSS.
|
I was trying to review but I'm not sure what the correct behavior is. A heading with no defined alignment goes to the right on RTL site, the rest goes to the alignment that was selected in the editor, is that correct? If so, then this looks fine to me:
|
|
Looking at this some more I think it's a bad idea, see #2551 (comment) |
|
This is what I’m getting on my end with RTL turned on inside of a group block:
Looks like the alignment is still getting reversed in RTL, and I think its supposed to stay persistent regardless of the RTL setting.
For other text-align utility class rules we’re using a Sass flag to ignore the RTL so the floating position isn’t automatically flipped, which breaks the expected behavior. See here: themes/varia/sass/blocks/utilities/_style.scss Lines 6 to 10 in 96c77a2 |
|
I wonder if we can just remove these rules and let core handle it all? |
This is a different approach to #2551 which fixes all Varia based themes.