Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter Templates: RTL issues #46435

Open
emilyaudela opened this issue Oct 14, 2020 · 9 comments
Open

Starter Templates: RTL issues #46435

emilyaudela opened this issue Oct 14, 2020 · 9 comments
Labels
[Goal] WPCOM Patterns Toolkit Attached to issues and PR related to our block patterns translations project. [Pri] Low Address when resources are available. [Type] Janitorial

Comments

@emilyaudela
Copy link
Contributor

In some of the starter templates for Gutenboarding, the right-to-left elements are not correct. Please correct the right-to-left layout in these starter templates.

Maywood

  1. Starting at URL: https://wordpress.com/new/design/ar
  2. Select the Maywood template
  3. The heading and first paragraph or the second section is not aligned right in the preview

capture-decran-2020-10-13-155510

Alves

  1. Starting at URL: https://wordpress.com/new/design/ar
  2. Select the Alves template
  3. The "About" text block is not right aligned

Screen Shot 2020-10-13 at 8 19 25 PM

Stratford

  1. Starting at URL: https://wordpress.com/new/design/ar
  2. Select the Stratford template
  3. The "Services" and "Testimonial" headings should be right aligned.

Screen Shot 2020-10-13 at 8 23 43 PM

Screen Shot 2020-10-13 at 8 22 37 PM

@emilyaudela emilyaudela added the [Goal] WPCOM Patterns Toolkit Attached to issues and PR related to our block patterns translations project. label Oct 14, 2020
@andrewserong
Copy link
Member

I think some of these are due to missing CSS rules in Varia or the child themes. @ramonjd has a PR for addressing Stratford in Automattic/themes#2551, but I'm wondering if that same change needs to happen higher up the chain in Varia 🤔

@ramonjd
Copy link
Member

ramonjd commented Oct 14, 2020

wondering if that same change needs to happen higher up the chain in Varia

I took a poke around and saw that there is a rebuild-child-themes script in the pub/varia directory. 🤞 we can change it in one place and recompile.

@ramonjd ramonjd added the [Pri] Low Address when resources are available. label Oct 19, 2020
@simison
Copy link
Member

simison commented Oct 28, 2020

I think this would be best handled by theme team since it affects current themes and live sites. @scruffian what do you think?

@scruffian
Copy link
Member

Yeah lets make this change in Varia and rebuild the children. Let me know if you need any help with this.

@simison
Copy link
Member

simison commented Oct 28, 2020

@scruffian Yeah, was hoping if Theme-folks could take this whole fix over?

@scruffian
Copy link
Member

Ok, added to the backlog. Not sure when we'll get to it...

@danieldudzic
Copy link
Contributor

Hi all!

Thank you for bringing this to the attention of the Theme team.

We have looked at the issue together and were able to replicate it.

We believe that the culprit here are the templates themselves.

The faulty blocks have alignment set via Block settings.

A paragraph aligned to the left should and will display as aligned to the left both in LTR and RTL.

The resolution here is not a CSS fix, but rather the removing of unnecessary alignment settings from the blocks (setting it back to Default).

@simison
Copy link
Member

simison commented Feb 9, 2021

Nice sleuthing @danieldudzi! 👏 @ianstewart can your team review the templates here? See above comment.

@ianstewart
Copy link
Contributor

@simison 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] WPCOM Patterns Toolkit Attached to issues and PR related to our block patterns translations project. [Pri] Low Address when resources are available. [Type] Janitorial
Projects
None yet
Development

No branches or pull requests

8 participants