Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block themes - update templateParts json #3511

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

Addison-Stavlo
Copy link
Contributor

Changes proposed in this Pull Request:

json schema for template parts and their area terms was recently updated in WordPress/gutenberg#29828. Here, we update this for seedlet-blocks as well as add this json for mayland-blocks. This allows template parts defined by the theme to render under their corresponding block variations by default.

For example, when inspecting the header for mayland-blocks, we can see the block has the expected 'header' variation by presence of the block variations icon throughout the interface:

Screen Shot 2021-03-22 at 5 22 40 PM

Related issue(s):

@Addison-Stavlo Addison-Stavlo self-assigned this Mar 22, 2021
@kjellr kjellr requested a review from a team March 23, 2021 13:51
Copy link
Contributor

@danieldudzic danieldudzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this for both Mayland Blocks and Seedlet Blocks and it works fine 👍

test

@pbking pbking force-pushed the update/block-themes-json-for-template-parts branch from 7cbe429 to 2600326 Compare March 25, 2021 13:09
@pbking pbking force-pushed the update/block-themes-json-for-template-parts branch from 2600326 to f8f5d39 Compare March 25, 2021 13:29
@pbking
Copy link
Contributor

pbking commented Mar 25, 2021

c-D59303

@pbking pbking merged commit 3335990 into trunk Mar 25, 2021
@pbking pbking deleted the update/block-themes-json-for-template-parts branch March 25, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants