Seedlet: Fix a fatal error in Gutenberg #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bf4fb9 introduced a bug when including `wpcom-colors.php` by using the editor. It was missing a directory separate and so it fataled with an error message like: `PHP Fatal error: Uncaught Error: Failed opening required '/xxx/seedlet/incwpcom-colors.php' (include_path='.') in /xxx/seedlet/inc/wpcom-editor-colors.php:3
Preview changesI've detected changes to the following themes in this PR: Seedlet. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
@dsas, I am still seeing this error in production. Should it be working by now? Thank you! |
|
@mrfoxtalbot bear with me, I'm having a deployment nightmare |
|
@mrfoxtalbot ok, I've deployed Seedlet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4bf4fb9 introduced a bug when including
wpcom-colors.phpby using the editor. It was missing a directory separate and so it fataled with an error message like:`PHP Fatal error: Uncaught Error: Failed opening required '/xxx/seedlet/incwpcom-colors.php' (include_path='.') in /xxx/seedlet/inc/wpcom-editor-colors.php:3
Changes proposed in this Pull Request:
Related issue(s):
#7937