Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-env): vip dev-env info --all should not ask for a slug #1815

Merged
merged 1 commit into from
May 9, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented May 2, 2024

Description

This PR fixes the bug when vip dev-env info --all asks for a slug when more than one environment is available.

Pull request checklist

New release checklist

Steps to Test

  1. vip dev-env create -s test1 < /dev/null
  2. vip dev-env create -s test2 < /dev/null
  3. vip dev-env info --all
  4. The last command should fail with something like "Error: More than one environment found: test1, test2. Please re-run command with the --slug parameter for the targeted environment."
  5. Apply the patch, run npm run build, npm link.
  6. vip dev-env info --all should succeed now.

@sjinks sjinks added [Type] Bug Something isn't working [Status] Needs Review labels May 2, 2024
@sjinks sjinks self-assigned this May 2, 2024
@sjinks sjinks changed the title dix(dev-env): vip dev-env info --all should not ask for a slug fix(dev-env): vip dev-env info --all should not ask for a slug May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rebeccahum rebeccahum merged commit 205145a into trunk May 9, 2024
17 checks passed
@rebeccahum rebeccahum deleted the fix/dev-env-info branch May 9, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants