This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Improve the JavaScript escaping example #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifying the "Escaping Dynamic JavaScript Values" example with do and don't do. We can still leave the script where it is for people who just want to see the right code, but when showing an example with incorrect code - I think it's better to have the correct code alongside as well. Also added `<?php` and `?>` with empty comments to enable proper syntax highlighting
rogertheriault
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying the "Escaping Dynamic JavaScript Values" example with do's and don't do's. We can still leave the script where it is for people who just want to see the right code, but when showing an example with incorrect code - I think it's better to have the correct code alongside as well.
Also added
<?phpand?>with empty comments to enable proper syntax highlighting