Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added actions, reducers & selectors to fetch the shipping methods configured for a shipping zone #14697

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

DanReyLop
Copy link
Contributor

Fixes #14265

In a63e21f I moved the "LOADING" constant into the wc-api/reducer.js file, even if it's still not an ideal solution, it's better than defining the same constant in every reducer.

The bulk of the PR is in c24e078 . It adds the property methodIds (an array of numbers) to each shipping zone. Those IDs will correspond with the shipping methods that are configured for that particular zone. Each method settings will instead be stores in the shippingZoneMethods subreee, which will be an object keyed by the numeric id of the method.

It doesn't have any frontend code, so the only way to test it is to run the tests.

@DanReyLop DanReyLop added Store [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Tests] Includes Tests labels Jun 1, 2017
@DanReyLop DanReyLop self-assigned this Jun 1, 2017
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Jun 1, 2017
@DanReyLop DanReyLop changed the title Add/14265 wc api get zone methods Added actions, reducers & selectors to fetch the shipping methods configured for a shipping zone Jun 6, 2017
Copy link
Contributor

@marcinbot marcinbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@DanReyLop DanReyLop force-pushed the add/14264-wc-api-get-shipping-methods branch from a647fe7 to 877948f Compare June 7, 2017 19:37
@matticbot
Copy link
Contributor

@DanReyLop This PR needs a rebase

@DanReyLop DanReyLop force-pushed the add/14265-wc-api-get-zone-methods branch from c24e078 to c6da24b Compare June 7, 2017 22:38
@DanReyLop DanReyLop changed the base branch from add/14264-wc-api-get-shipping-methods to master June 7, 2017 22:39
@DanReyLop DanReyLop merged commit 0552cf0 into master Jun 7, 2017
@DanReyLop DanReyLop deleted the add/14265-wc-api-get-zone-methods branch June 7, 2017 22:46
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Size] XL Probably needs to be broken down into multiple smaller issues [Status] Needs Rebase Store [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants