Added actions, reducers & selectors to fetch the locations from the WooCommerce host. #15032
Conversation
DanReyLop
added
Store
[Status] Needs Review
matticbot
added
the
[Size] XL
| * @return {Array} The locations tree, as retrieved from the server. It can also be the string "LOADING" | ||
| * if the locations are currently being fetched, or a "falsy" value if that haven't been fetched at all. | ||
| */ | ||
| export const getRawLocations = ( state, siteId = getSelectedSiteId( state ) ) => { |
There was a problem hiding this comment.
do you need the Raw here?
There was a problem hiding this comment.
Is this being used somewhere else? From this PR it is not evident why it is being exported
There was a problem hiding this comment.
You're right, it doesn't need to be exported. Fixed.
|
@DanReyLop This PR needs a rebase |
| ], | ||
| }, | ||
| { | ||
| code: "AM", |
There was a problem hiding this comment.
Minor but this should be NA and North America.
| }, | ||
| ], | ||
| }, | ||
| { |
|
|
||
| const locations = [ | ||
| { | ||
| code: 'AM', |
| expect( hasStates( loadedState, 'SA' ) ).to.be.false; | ||
| } ); | ||
|
|
||
| it( 'should return true if the countri has states', () => { |
🤦♂️ fixed. It was just for an example, but I should have looked at the real values anyway :) |
|
@DanReyLop This PR needs a rebase |
|
@belcherj @justinshreve Can I please get another quick 👀? I've fixed the comments you had. |
justinshreve
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Fixes #14266
This PR adds logic to fetch locations data from the WooCommerce server. It uses the new
v3/data/continentsendpoint (from here). Since each continent already is returned with all the info for all its countries, and every country is returned with all the info for all its states, there's no need to hit any other endpoint.The data is stored as it comes from the server, but I've added a few selectors to "query" it. Since there are quite a few countries in the world, maybe I've been too negligent with performance. When this is hooked to an actual UI, I'll measure and if needed optimize the data structures or add memoizing to the selectors.
There is no way to test it in the UI, so just run the tests.