Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "getCountryName" selector #15548

Merged
merged 3 commits into from
Jun 28, 2017

Conversation

DanReyLop
Copy link
Contributor

Fixes #14274

Adds a "getCountryName" selector. For a given country code, it returns its name.

It's not currently used, so just check that tests pass.

@DanReyLop DanReyLop added Store [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Tests] Includes Tests labels Jun 27, 2017
@DanReyLop DanReyLop self-assigned this Jun 27, 2017
@matticbot matticbot added the [Size] M Medium sized issue label Jun 27, 2017
@matticbot
Copy link
Contributor

Copy link
Contributor

@marcinbot marcinbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

Copy link
Contributor

@justinshreve justinshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass. Change LGTM.

One optional note below.

@@ -72,6 +72,23 @@ export const getCountries = ( state, continentCode, siteId = getSelectedSiteId(
* @param {Object} state Whole Redux state tree
* @param {String} countryCode 2-letter ISO country code
* @param {Number} [siteId] Site ID to check. If not provided, the Site ID selected in the UI will be used
* @return {String} The country name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that the countryCode will sometimes be returned if a country name can't be found/loaded.

@justinshreve justinshreve added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 27, 2017
Daniel Rey Lopez and others added 2 commits June 28, 2017 07:34
…s. (#15549)

* Added a helper to merge locations edits with temporary locations edits.

* Added "JOURNAL_ACTIONS" variable definition so tests can pass.

* Added actions & UI reducers for the shipping locations edit UI (#15550)

* Added actions & UI reducers for the shipping locations edit UI

* Added UI selectors for the Shipping Zone locations edit (#15551)

* Added UI selectors for the Shipping Zone locations edit

* Added missing "export".

* Added a selector to check if the zone currently being edited has a valid set of locations. (#15552)
@matticbot matticbot added [Size] XL Probably needs to be broken down into multiple smaller issues and removed [Size] M Medium sized issue labels Jun 28, 2017
@DanReyLop DanReyLop merged commit 744aa68 into master Jun 28, 2017
@DanReyLop DanReyLop deleted the add/14274-locations-ui-reducers-part-1 branch June 28, 2017 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Size] XL Probably needs to be broken down into multiple smaller issues Store [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants