Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Update Gridicons to v2.0.3 #17601

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Framework: Update Gridicons to v2.0.3 #17601

merged 1 commit into from
Aug 30, 2017

Conversation

jancavan
Copy link
Contributor

This PR updates Gridicons to v2.0.3 following this change: Automattic/gridicons#246

This version adds two new icons:

  1. Reader Follow Conversation
    screenshot 2017-08-29 10 23 50

  2. Reader Following Conversation
    screenshot 2017-08-29 10 23 52

The old Comment and Chat icons have also been updated to match this new style:

Comment before:
screenshot 2017-08-29 10 25 45

Comment after:
screenshot 2017-08-29 10 24 53

Chat before:
screenshot 2017-08-29 10 25 36

Chat after:
screenshot 2017-08-29 10 24 54

@jancavan jancavan self-assigned this Aug 29, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/gridicon/version2.0.3

@matticbot matticbot added the [Size] S Small sized issue label Aug 29, 2017
@jancavan
Copy link
Contributor Author

jancavan commented Aug 29, 2017 •
edited
Loading

Sidenote: I'm unable to name this branch update/gridicons/... so I used update/gridicon/... instead.

It throws this error?
fatal: cannot lock ref 'refs/heads/update/gridicons/version-2.0.3': 'refs/heads/update/gridicons' exists;

@gwwar
Copy link
Contributor

gwwar commented Aug 29, 2017

@jancavan you need to publish gridicons 2.0.3 to npm first 👍

From https://www.npmjs.com/package/gridicons latest version is still 2.0.2
screen shot 2017-08-29 at 10 31 03 am

gwwar
gwwar approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots! This tests well for me.

@rachelmcr rachelmcr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2017
@jancavan jancavan merged commit 9490f6b into master Aug 30, 2017
@jancavan jancavan deleted the update/gridicon/version2.0.3 branch August 30, 2017 16:56
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2017
@folletto folletto mentioned this pull request Sep 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwwar gwwar gwwar approved these changes

@folletto folletto Awaiting requested review from folletto

Assignees

@jancavan jancavan

Labels
Framework [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jancavan @matticbot @gwwar @rachelmcr