Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Boot: Don't render empty Layout" #28273

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Revert "Boot: Don't render empty Layout" #28273

merged 1 commit into from
Nov 5, 2018

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Nov 5, 2018

Reverts #26944 because of broken SSR for login page.

@jsnajdr jsnajdr self-assigned this Nov 5, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=revert-26944-remove/boot-empty-layout

@ghost
Copy link

ghost commented Nov 5, 2018

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️

"Testing instructions" are missing for this PR. Please add some.

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Calypso maintainers do their job. If you think 'Testing instructions' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@jsnajdr jsnajdr merged commit 042c8be into master Nov 5, 2018
@jsnajdr jsnajdr deleted the revert-26944-remove/boot-empty-layout branch November 5, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flootr flootr flootr approved these changes

Assignees

@jsnajdr jsnajdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsnajdr @matticbot @flootr