Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: DSS: Properly send image data to new site #296

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Signup: DSS: Properly send image data to new site #296

merged 1 commit into from
Nov 20, 2015

Conversation

sirbrillig
Copy link
Member

In a previous commit, the image data being sent to submitSignupStep was turned
into a string accidentally (it was changed to fix the stats).

Testing

  1. Visit http://calypso.localhost:3000/start/dss/ and go through the flow (search for something, select a screenshot with an image, complete the flow to create a new site).
  2. Visit the new site and make sure the image you chose is being used as the header image.

@sirbrillig
Signup: DSS: Properly send image data to new site
2b1a9c4 
In a previous commit, the image data being sent to `submitSignupStep` was turned
into a string accidentally (it was changed to fix the stats).
@sirbrillig sirbrillig added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. Dynamic Screenshots (DSS) labels Nov 20, 2015
@michaeldcain michaeldcain added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
@michaeldcain
Copy link
Member

LGTM

sirbrillig added a commit that referenced this pull request Nov 20, 2015
@sirbrillig
Merge pull request #296 from Automattic/fix/dss-saved-image
b58674e 
Signup: DSS: Properly send image data to new site
@sirbrillig sirbrillig merged commit b58674e into master Nov 20, 2015
@sirbrillig sirbrillig deleted the fix/dss-saved-image branch November 20, 2015 18:49
@snyk-bot snyk-bot mentioned this pull request Oct 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Nov 17, 2020
Open
@anarh anarh mentioned this pull request Jan 21, 2021
Open
@mdno mdno mentioned this pull request Jan 22, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
This was referenced May 10, 2022
Open
Open
@mdno mdno mentioned this pull request Oct 30, 2022
Open
@anarh anarh mentioned this pull request Oct 31, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Feb 2, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 1, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 22, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Apr 16, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirbrillig @michaeldcain @scruffian