Domains: New onboarding doen't show .blog subdomains #30914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidvu
added
NUX
[Feature Group] Emails & Domains
aidvu
commented
Feb 20, 2019
| siteGoalsArray.length === 1 && | ||
| siteGoalsArray.indexOf( 'share' ) !== -1 ) | ||
| // All flows where 'about' step is before 'domains' step, user picked only 'share' on the `about` step | ||
| ( ( siteGoalsArray.length === 1 && siteGoalsArray.indexOf( 'share' ) !== -1 ) || |
There was a problem hiding this comment.
This horrible alignment was by the linter, or whatever refactors the code these days. 😆
|
Note that I tested from an incognito window and straight from |
klimeryk
added
the
[Status] Needs Review
|
@aidvu remember to add the |
|
Ooops, thanks @klimeryk. |
klimeryk
added
[Status] Needs Review
Update to show .blog subdomains when a user selects `Blog` as the site type for their new site.
aidvu
force-pushed
the
update/fix-new-flow-dotblog-subdomains
branch
from
361a88a
to
3c51828
Compare
aidvu
added
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Update to show .blog subdomains when a user selects
Blogas the site type for their new site.Testing instructions
/startimprovedOnboardingA/B test hasonboardingselectedBlog