Jetpack Plans Price Toggle: CSS selector that sets margin should be more specific #35607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore specific Turn the `.price-toggle` CSS selector into `.segmented-control.price-control`, to make sure that it always overrides the base `.segmented-control` styles.
jsnajdr
added
[Type] Bug
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
removed
the
[Status] Needs Review
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the
.price-toggleCSS selector into.segmented-control.price-control, to make surethat it always overrides the base
.segmented-controlstyles.Fixes a regression introduced in #35051 and reported by @simison in #35051 (comment)
How to test:
Verify that the bug reported by @simison no longer happens. I.e., the placement of the Monthly/Yearly toggle is not broken like here:
Note that the bug is non-deterministic: depends on the exact order of how CSS chunks are loaded, which depends on navigation history etc.