Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Contrast and gridicon update to full screen site picker #360

Merged
merged 2 commits into from
Nov 24, 2015

Conversation

kellychoffman
Copy link
Member

When the recent background color change, the site cards with empty headers were fading into the background:

screen shot 2015-11-20 at 3 48 29 pm

I updated the color and replaced the noticon in the 'Start A New WordPress' card to a gridicon.

screen shot 2015-11-20 at 4 38 28 pm

To test, visit /post.

@kellychoffman kellychoffman added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Nov 20, 2015
@kellychoffman kellychoffman self-assigned this Nov 20, 2015
@apeatling
Copy link
Member

👍 GTM

@apeatling apeatling added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 24, 2015
kellychoffman added a commit that referenced this pull request Nov 24, 2015
Framework: Contrast and gridicon update to full screen site picker
@kellychoffman kellychoffman merged commit 79f0706 into master Nov 24, 2015
@kellychoffman kellychoffman deleted the fix/site-picker-contrast branch November 24, 2015 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants