Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite checkout: Remove private key file #37610

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

fditrapani
Copy link
Contributor

@fditrapani fditrapani commented Nov 14, 2019

Changes proposed in this Pull Request

This PR removes a file that shouldn't have been committed.

Per Stripe's Docs, it's not sensitive information, though: https://stripe.com/docs/keys

Publishable API keys are meant solely to identify your account with Stripe, they aren't secret. In other words, they can safely be published in places like your Stripe.js JavaScript code, or in an Android or iPhone app. Publishable keys only have the power to create tokens.

@fditrapani fditrapani self-assigned this Nov 14, 2019
@matticbot
Copy link
Contributor

@sirbrillig sirbrillig changed the title Composite checkout: Remove file Composite checkout: Remove private key file Nov 14, 2019
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fditrapani fditrapani merged commit d7a90c0 into master Nov 14, 2019
@fditrapani fditrapani deleted the remove/composite-checkout-file branch November 14, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants